Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chat refactor] 채팅의 default 네브바와 input ui를 추가합니다. #2982

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

dongoc
Copy link
Contributor

@dongoc dongoc commented Nov 3, 2023

PR 설명

[Chat Refactor]
기존 ChatContainer에서 navbar와 input을 prop으로 받아 렌더링하는 방식은 실시간 렌더링 변화를 감지하지 못했던 문제가 있었습니다. ChatContainer를 제거하면서 default navbar와 input의 UI를 별도로 제공합니다. 각 프로젝트 상황에 따라 해당 UI를 사용하지 않을 수 있습니다.

변경 내역

  • 디폴트 navbar, input UI를 제공합니다.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 146 lines in your changes are missing coverage. Please review.

Comparison is base (b7a7a46) 12.17% compared to head (fa9f8c1) 12.08%.
Report is 9 commits behind head on epic/chat-refactor.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           epic/chat-refactor    #2982      +/-   ##
======================================================
- Coverage               12.17%   12.08%   -0.10%     
======================================================
  Files                     687      690       +3     
  Lines                   36212    36482     +270     
  Branches                 8941     9007      +66     
======================================================
  Hits                     4410     4410              
- Misses                  31795    32065     +270     
  Partials                    7        7              
Files Coverage Δ
packages/chat/src/input-area/elements.ts 0.00% <0.00%> (ø)
packages/chat/src/navbar/index.tsx 0.00% <0.00%> (ø)
packages/chat/src/input-area/index.tsx 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dongoc dongoc self-assigned this Nov 6, 2023
@dongoc dongoc added this to the v13.chat-refactor milestone Nov 6, 2023
@dongoc dongoc marked this pull request as ready for review November 6, 2023 07:28
@dongoc dongoc requested a review from a team as a code owner November 6, 2023 07:28
@dongoc dongoc requested review from zzolain, choisohyun and guswl98 and removed request for a team November 6, 2023 07:28
@dongoc dongoc marked this pull request as draft November 6, 2023 07:30
@dongoc dongoc marked this pull request as ready for review November 7, 2023 01:55
@choisohyun
Copy link
Contributor

실시간 렌더링 변화를 감지하지 못했던 문제는 어떤 경우였을까요?? 인풋창이 UI가 변경되어야 하는데 변경이 안되거나 하는 이슈였을까요??

@dongoc
Copy link
Contributor Author

dongoc commented Nov 7, 2023

실시간 렌더링 변화를 감지하지 못했던 문제는 어떤 경우였을까요?? 인풋창이 UI가 변경되어야 하는데 변경이 안되거나 하는 이슈였을까요??

기존의 ChatContainer 컴포넌트에서 Container와 Input을 prop으로 받아 렌더링할 때 요런 문제가 있었습니다😂
컨테이너에 동적인 css를 넣으려고 우회를 하면 컨테이너 안의 새로운 메세지들이 렌더링이 안되는 문제여서
아예 패키지에서 Container와 Input을 조합해주는 코드를 제거하고 따로 UI로 제공하자!는 게 취지였습니다.

@choisohyun
Copy link
Contributor

저런 이슈가 있었군요... 😱 이해했습니다 ㅜㅜ

@dongoc dongoc merged commit fce9b92 into epic/chat-refactor Nov 8, 2023
8 checks passed
@dongoc dongoc deleted the feature/default-room-ui branch November 8, 2023 08:38
@dongoc dongoc mentioned this pull request Jan 10, 2024
@dongoc dongoc mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants