-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chat refactor] BubbleUI의 prop 변경 #2998
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
내부에서 사용하는 useChat 제거
dongoc
reviewed
Nov 14, 2023
dongoc
reviewed
Nov 14, 2023
dongoc
approved these changes
Nov 14, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## epic/chat-refactor #2998 +/- ##
======================================================
- Coverage 11.89% 11.89% -0.01%
======================================================
Files 697 697
Lines 37062 37073 +11
Branches 9122 9121 -1
======================================================
Hits 4410 4410
- Misses 32645 32656 +11
Partials 7 7 ☔ View full report in Codecov by Sentry. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 설명
BubbleUI
는 들어오는 타입에 따라 알맞는 Bubble을 렌더링하는 역할을 합니다. 기존에는 type에 맞는 prop들만 넘길 수 있게 되어있었으나, 컴포넌트의 목적과 사용의 편리함을 위해 버블의 타입에 상관없이 종합적으로 필요한 prop을 모두 받아BubbleUI
내부에서 각 Bubble에 맞는 prop을 넘기는 형태로 수정합니다.변경 내역
체크리스트
스크린샷 & URL