Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chat refactor] BubbleUI의 prop 변경 #2998

Merged
merged 5 commits into from
Nov 15, 2023
Merged

Conversation

guswl98
Copy link
Contributor

@guswl98 guswl98 commented Nov 14, 2023

PR 설명

BubbleUI는 들어오는 타입에 따라 알맞는 Bubble을 렌더링하는 역할을 합니다. 기존에는 type에 맞는 prop들만 넘길 수 있게 되어있었으나, 컴포넌트의 목적과 사용의 편리함을 위해 버블의 타입에 상관없이 종합적으로 필요한 prop을 모두 받아 BubbleUI 내부에서 각 Bubble에 맞는 prop을 넘기는 형태로 수정합니다.

변경 내역

체크리스트

스크린샷 & URL

@guswl98 guswl98 added this to the v13.chat-refactor milestone Nov 14, 2023
@guswl98 guswl98 requested review from choisohyun and dongoc November 14, 2023 06:06
@guswl98 guswl98 requested a review from a team as a code owner November 14, 2023 06:06
@guswl98 guswl98 self-assigned this Nov 14, 2023
@guswl98 guswl98 requested review from dia-triple and removed request for a team November 14, 2023 06:06
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (cf95303) 11.89% compared to head (3038fe0) 11.89%.

Files Patch % Lines
packages/chat/src/bubble/bubble-ui.tsx 0.00% 50 Missing ⚠️
packages/chat/src/chat/chat.tsx 0.00% 7 Missing ⚠️
packages/chat/src/bubble/bubble.tsx 0.00% 2 Missing ⚠️
packages/chat/src/bubble/rich.tsx 0.00% 2 Missing ⚠️
packages/chat/src/utils/constants.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           epic/chat-refactor    #2998      +/-   ##
======================================================
- Coverage               11.89%   11.89%   -0.01%     
======================================================
  Files                     697      697              
  Lines                   37062    37073      +11     
  Branches                 9122     9121       -1     
======================================================
  Hits                     4410     4410              
- Misses                  32645    32656      +11     
  Partials                    7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guswl98 guswl98 merged commit f3131d5 into epic/chat-refactor Nov 15, 2023
7 checks passed
@guswl98 guswl98 deleted the fix/bubble-ui branch November 15, 2023 01:10
@dongoc dongoc mentioned this pull request Jan 10, 2024
@dongoc dongoc mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants