Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chat refactor] 사용하지 않는 파일을 제거합니다. #2999

Merged
merged 5 commits into from
Nov 17, 2023

Conversation

dongoc
Copy link
Contributor

@dongoc dongoc commented Nov 15, 2023

PR 설명

  • bubble에서 사용하는 useChat context가 제거됨에 따라 사용하지 않는 기존의 Chat, ChatContainer, useChatMessage, reducer 파일을 삭제합니다. Chat, ChatContainer는 각 프로젝트에서 Bubble을 사용하여 직접 렌더링하거나 이후 작업할 Messages 컴포넌트로 대체할 수 있습니다.
  • 누락된 export를 추가합니다.

@dongoc dongoc added this to the v13.chat-refactor milestone Nov 15, 2023
@dongoc dongoc self-assigned this Nov 15, 2023
@dongoc dongoc force-pushed the epic/chat-refactor branch from f3131d5 to 1eac473 Compare November 16, 2023 01:20
@dongoc dongoc force-pushed the delete/chat-container branch from fb83c70 to 4ce745a Compare November 16, 2023 04:28
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (80b5a85) 11.84% compared to head (d9b75da) 12.07%.

Files Patch % Lines
...ges/chat/src/bubble-container/bubble-container.tsx 0.00% 7 Missing ⚠️
packages/chat/src/chat/scroll-context.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           epic/chat-refactor    #2999      +/-   ##
======================================================
+ Coverage               11.84%   12.07%   +0.22%     
======================================================
  Files                     699      693       -6     
  Lines                   37222    36533     -689     
  Branches                 9162     8956     -206     
======================================================
  Hits                     4410     4410              
+ Misses                  32805    32116     -689     
  Partials                    7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dongoc
Copy link
Contributor Author

dongoc commented Nov 16, 2023

release-canary

Copy link

v13.11.1-pr-2999.46 has been published!

@dongoc dongoc marked this pull request as ready for review November 16, 2023 06:20
@dongoc dongoc requested a review from a team as a code owner November 16, 2023 06:20
@dongoc dongoc requested review from drakang4, choisohyun, sohnjunior and guswl98 and removed request for a team November 16, 2023 06:20
@dongoc dongoc force-pushed the delete/chat-container branch from f5a8d2c to d9b75da Compare November 16, 2023 07:21
@dongoc
Copy link
Contributor Author

dongoc commented Nov 16, 2023

release-canary

Copy link

v13.11.1-pr-2999.48 has been published!

@dongoc dongoc merged commit 462f642 into epic/chat-refactor Nov 17, 2023
11 checks passed
@dongoc dongoc deleted the delete/chat-container branch November 17, 2023 04:06
@dongoc dongoc mentioned this pull request Jan 10, 2024
@dongoc dongoc mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants