Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chat refactor] Bubble의 default click 설정 #3008

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

guswl98
Copy link
Contributor

@guswl98 guswl98 commented Nov 23, 2023

PR 설명

ImageBubbleTextBubble, RichBubble 내의 a tag의 default click 이벤트를 설정합니다. ImageBubble의 경우 앱 내에서 이미지를 클릭 시 이미지 확대뷰를 노출합니다. TextBubble, RichBubble 내의 a tag 클릭 시 해당 링크를 오픈합니다.
a-tag-navigator.ts 기능을 개발하면서 사용한 router 패키지에서 i18n.d.ts 파일을 요구해 이를 추가합니다. 해당 파일에서 import 중인 패키지들을 devDependency에 추가합니다.

Messages 컴포넌트에서 onRetry, onRetryCancel 클릭 이벤트를 전달합니다.

변경 내역

체크리스트

스크린샷 & URL

@guswl98 guswl98 added this to the v13.chat-refactor milestone Nov 23, 2023
@guswl98 guswl98 self-assigned this Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (c1045a1) 12.04% compared to head (af4d3f2) 12.03%.

Files Patch % Lines
packages/chat/src/utils/a-tag-navigator.ts 0.00% 13 Missing ⚠️
packages/chat/src/bubble/image.tsx 0.00% 6 Missing ⚠️
packages/chat/src/bubble/text.tsx 0.00% 4 Missing ⚠️
packages/chat/src/bubble/bubble-ui.tsx 0.00% 2 Missing ⚠️
packages/chat/src/messages.tsx 0.00% 2 Missing ⚠️
packages/chat/src/utils/image.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           epic/chat-refactor    #3008      +/-   ##
======================================================
- Coverage               12.04%   12.03%   -0.01%     
======================================================
  Files                     695      696       +1     
  Lines                   36616    36638      +22     
  Branches                 8981     8988       +7     
======================================================
  Hits                     4410     4410              
- Misses                  32199    32221      +22     
  Partials                    7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guswl98 guswl98 force-pushed the feature/message/click branch from d47f21a to 4d50533 Compare November 23, 2023 06:09
@guswl98
Copy link
Contributor Author

guswl98 commented Nov 24, 2023

release-canary

@guswl98
Copy link
Contributor Author

guswl98 commented Nov 24, 2023

release-canary

Copy link

v13.11.1-pr-3008.75 has been published!

@guswl98
Copy link
Contributor Author

guswl98 commented Nov 24, 2023

release-canary

Copy link

v13.11.1-pr-3008.76 has been published!

@guswl98 guswl98 requested a review from dongoc November 24, 2023 08:35
@guswl98 guswl98 marked this pull request as ready for review November 24, 2023 08:36
@guswl98 guswl98 requested a review from a team as a code owner November 24, 2023 08:36
@guswl98 guswl98 requested review from inbeom and torres-triple and removed request for a team November 24, 2023 08:36
@guswl98 guswl98 merged commit f48f192 into epic/chat-refactor Nov 27, 2023
12 checks passed
@guswl98 guswl98 deleted the feature/message/click branch November 27, 2023 01:02
@dongoc dongoc mentioned this pull request Jan 10, 2024
@dongoc dongoc mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants