-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chat refactor] Bubble의 default click 설정 #3008
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files
☔ View full report in Codecov by Sentry. |
guswl98
force-pushed
the
feature/message/click
branch
from
November 23, 2023 06:09
d47f21a
to
4d50533
Compare
release-canary |
release-canary |
v13.11.1-pr-3008.75 has been published! |
release-canary |
v13.11.1-pr-3008.76 has been published! |
guswl98
requested review from
inbeom and
torres-triple
and removed request for
a team
November 24, 2023 08:36
dongoc
approved these changes
Nov 27, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 설명
ImageBubble
과TextBubble, RichBubble
내의 a tag의 default click 이벤트를 설정합니다.ImageBubble
의 경우 앱 내에서 이미지를 클릭 시 이미지 확대뷰를 노출합니다.TextBubble, RichBubble
내의 a tag 클릭 시 해당 링크를 오픈합니다.a-tag-navigator.ts
기능을 개발하면서 사용한 router 패키지에서i18n.d.ts
파일을 요구해 이를 추가합니다. 해당 파일에서 import 중인 패키지들을 devDependency에 추가합니다.Messages
컴포넌트에서 onRetry, onRetryCancel 클릭 이벤트를 전달합니다.변경 내역
체크리스트
스크린샷 & URL