Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chat] 좋아요 기능 추가 #3017

Merged
merged 18 commits into from
Dec 11, 2023
Merged

[Chat] 좋아요 기능 추가 #3017

merged 18 commits into from
Dec 11, 2023

Conversation

guswl98
Copy link
Contributor

@guswl98 guswl98 commented Nov 28, 2023 •
edited
Loading

PR 설명

이벤트챗에서 사용될 좋아요 기능을 추가합니다. 관련 위키

변경 내역

좋아요 버튼 추가

  • 좋아요, 좋아요 취소 가능
  • blind된 메세지에는 노출되지 않음

좋아요 기능은 이벤트챗에서만 사용되지만 챗의 종류에 상관없이 API에서 reactions 값을 넘겨주기 때문에 기본챗(파트너센터)의 메세지들에서 thanks를 undefined로 넘겨주려고 했습니다. 그러나 과거 메세지 fetch가 TF 내에서 일어나고 있어서 chat-web에서 undefined로 바꿔주기 + TF에서 undefined로 바꿔주기 모두 필요한 상황이었습니다. 현재 리팩토링도 진행되고 있기 때문에 당장은 좀 더 간단한 로직을 갖고가기 위해 ChatBubble에서 ChatBubbleUI로 넘겨줄 때 채팅방의 타입을 구분해 값을 넘겨주기로 하였습니다.

체크리스트

스크린샷 & URL

image

@guswl98 guswl98 added the chat label Nov 28, 2023
@guswl98 guswl98 added this to the v13.12.0 milestone Nov 28, 2023
@guswl98 guswl98 self-assigned this Nov 28, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2023 •
edited
Loading

Codecov Report

Attention: 116 lines in your changes are missing coverage. Please review.

Comparison is base (ea2ffff) 12.09% compared to head (c2c7d14) 12.05%.
Report is 21 commits behind head on main.

Files Patch % Lines
packages/chat/src/chat-bubble/chat-bubble-ui.tsx 0.00% 52 Missing ⚠️
packages/chat/src/chat-bubble/thanks.tsx 0.00% 28 Missing ⚠️
packages/chat/src/chat/chat.tsx 0.00% 28 Missing ⚠️
packages/chat/src/chat/reducer.ts 0.00% 4 Missing ⚠️
packages/chat/src/utils/constants.ts 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3017      +/-   ##
==========================================
- Coverage   12.09%   12.05%   -0.05%     
==========================================
  Files         691      692       +1     
  Lines       36451    36597     +146     
  Branches     8996     9046      +50     
==========================================
  Hits         4410     4410              
- Misses      32034    32180     +146     
  Partials        7        7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guswl98
Copy link
Contributor Author

guswl98 commented Nov 28, 2023

release-canary

@guswl98 guswl98 removed this from the v13.12.0 milestone Nov 28, 2023
@github-actions GitHub Actions
Copy link

v13.11.1-pr-3017.11 has been published!

@guswl98
Copy link
Contributor Author

guswl98 commented Nov 28, 2023

release-canary

@github-actions GitHub Actions
Copy link

v13.11.1-pr-3017.12 has been published!

@guswl98
Copy link
Contributor Author

guswl98 commented Nov 28, 2023

release-canary

@github-actions GitHub Actions
Copy link

v13.11.1-pr-3017.13 has been published!

@guswl98 guswl98 force-pushed the feature/message-thanks branch from 50e8ef3 to 729025d Compare November 29, 2023 08:30
@guswl98
Copy link
Contributor Author

guswl98 commented Nov 30, 2023

release-canary

@github-actions GitHub Actions
Copy link

v13.11.1-pr-3017.15 has been published!

@guswl98
Copy link
Contributor Author

guswl98 commented Nov 30, 2023

release-canary

@github-actions GitHub Actions
Copy link

v13.11.1-pr-3017.16 has been published!

@guswl98
Copy link
Contributor Author

guswl98 commented Dec 1, 2023

release-canary

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

v13.11.1-pr-3017.17 has been published!

@guswl98
Copy link
Contributor Author

guswl98 commented Dec 1, 2023

release-canary

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

v13.11.1-pr-3017.18 has been published!

@guswl98
Copy link
Contributor Author

guswl98 commented Dec 4, 2023

release-canary

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

v13.11.1-pr-3017.19 has been published!

@guswl98
Copy link
Contributor Author

guswl98 commented Dec 5, 2023

release-canary

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

v13.11.1-pr-3017.20 has been published!

@guswl98
Copy link
Contributor Author

guswl98 commented Dec 5, 2023

release-canary

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

v13.11.1-pr-3017.21 has been published!

@guswl98 guswl98 requested a review from dongoc December 5, 2023 07:44
@guswl98 guswl98 marked this pull request as ready for review December 5, 2023 07:44
@guswl98 guswl98 requested a review from a team as a code owner December 5, 2023 07:44
@guswl98 guswl98 requested review from sohnjunior and jhyj0521 and removed request for a team December 5, 2023 07:44
dongoc
dongoc previously approved these changes Dec 6, 2023
View reviewed changes
zhsks528
zhsks528 previously approved these changes Dec 6, 2023
View reviewed changes
@guswl98 guswl98 dismissed stale reviews from zhsks528 and dongoc via c2c7d14 December 7, 2023 00:15
@guswl98 guswl98 added this to the v13.14.0 milestone Dec 11, 2023
@guswl98 guswl98 merged commit b18e265 into main Dec 11, 2023
7 checks passed
@guswl98 guswl98 deleted the feature/message-thanks branch December 11, 2023 05:15
@dongoc dongoc mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongoc dongoc dongoc approved these changes

@choisohyun choisohyun choisohyun approved these changes

@zhsks528 zhsks528 zhsks528 left review comments

@sohnjunior sohnjunior Awaiting requested review from sohnjunior sohnjunior is a code owner automatically assigned from titicacadev/frontend

@jhyj0521 jhyj0521 Awaiting requested review from jhyj0521 jhyj0521 is a code owner automatically assigned from titicacadev/frontend

Assignees

@guswl98 guswl98

Labels
chat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guswl98 @choisohyun @dongoc @zhsks528