Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chat refactor] scroll context에 스크롤 방지 옵션을 추가합니다. #3051

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

dongoc
Copy link
Contributor

@dongoc dongoc commented Dec 8, 2023

PR 설명

scroll context에 스크롤 방지 옵션을 추가합니다.

  • setScrollY, setScrollBy의 역스크롤 현상을 방지하는 데 사용합니다.
  • 스크롤이 걸린 로직의 예외처리를 할 때 사용합니다.(예시: 부모 메세지 preview를 닫을 때 default 스크롤 방지)

@dongoc dongoc added the chat label Dec 8, 2023
@dongoc dongoc added this to the v13.chat-refactor milestone Dec 8, 2023
@dongoc dongoc self-assigned this Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (703d85f) 12.03% compared to head (88b74ca) 12.03%.

Files Patch % Lines
packages/chat/src/chat/scroll-context.tsx 0.00% 11 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           epic/chat-refactor    #3051      +/-   ##
======================================================
- Coverage               12.03%   12.03%   -0.01%     
======================================================
  Files                     696      696              
  Lines                   36638    36645       +7     
  Branches                 8988     8990       +2     
======================================================
  Hits                     4410     4410              
- Misses                  32221    32228       +7     
  Partials                    7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dongoc dongoc marked this pull request as ready for review December 14, 2023 04:41
@dongoc dongoc requested a review from a team as a code owner December 14, 2023 04:41
@dongoc dongoc requested review from zzolain, guswl98 and seulgiyoon and removed request for a team December 14, 2023 04:41
Copy link
Contributor

@guswl98 guswl98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스크롤 컨텍스트 로직이 복잡하긴 하군요 🥲

@dongoc
Copy link
Contributor Author

dongoc commented Dec 14, 2023

스크롤 컨텍스트 로직이 복잡하긴 하군요 🥲

스크롤 로직에 if문이 많더라구요..ㅋㅋㅋ🥲 감사합니당!

@dongoc dongoc merged commit 374cd42 into epic/chat-refactor Dec 14, 2023
10 checks passed
@dongoc dongoc deleted the add/export branch December 14, 2023 04:54
@dongoc dongoc mentioned this pull request Jan 10, 2024
@dongoc dongoc mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants