Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-hooks] user 타입에 email 필드를 추가합니다. #3304

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Conversation

dongoc
Copy link
Contributor

@dongoc dongoc commented Jul 5, 2024

PR 설명

[react-hooks] user 타입에 email 필드를 추가합니다.

  • GET /users/me API 응답값으로 email 필드가 추가되었습니다. (관련 스레드)

변경 내역

체크리스트

스크린샷 & URL

@dongoc dongoc self-assigned this Jul 5, 2024
@dongoc dongoc added this to the v13.26.2 milestone Jul 5, 2024
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 10.26%. Comparing base (5840cf4) to head (80c39fc).

Files Patch % Lines
...ackages/react-contexts/src/session-context/user.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              v13    #3304   +/-   ##
=======================================
  Coverage   10.26%   10.26%           
=======================================
  Files         710      710           
  Lines       33763    33763           
  Branches     9183     9183           
=======================================
  Hits         3465     3465           
  Misses      30291    30291           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dongoc dongoc marked this pull request as ready for review July 5, 2024 07:55
@dongoc dongoc requested a review from a team as a code owner July 5, 2024 07:55
@dongoc dongoc requested review from drakang4, guswl98 and torres-triple and removed request for a team July 5, 2024 07:55
@drakang4
Copy link
Contributor

drakang4 commented Jul 5, 2024

email은 어떻게 주입 받는건가요? api에도 추가된건가요?

@dongoc
Copy link
Contributor Author

dongoc commented Jul 5, 2024

email은 어떻게 주입 받는건가요? api에도 추가된건가요?

네네! 이번에 API에 필드로 추가되었습니다. (PR 설명에도 추가해둘게요!)

@dongoc
Copy link
Contributor Author

dongoc commented Jul 5, 2024

🙇‍♂️

@dongoc dongoc merged commit 60515b3 into v13 Jul 5, 2024
13 checks passed
@dongoc dongoc deleted the add/email branch July 5, 2024 09:04
@guswl98 guswl98 mentioned this pull request Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants