스토리북 8 업그레이드 #3341
Merged
스토리북 8 업그레이드 #3341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3341 +/- ##
=======================================
Coverage 14.77% 14.77%
=======================================
Files 721 721
Lines 10097 10097
Branches 3307 3307
=======================================
Hits 1492 1492
Misses 8182 8182
Partials 423 423 ☔ View full report in Codecov by Sentry. |
drakang4
requested review from
choisohyun,
jaehyeon48 and
YWTechIT
and removed request for
a team
dongoc
reviewed
Aug 9, 2024
Comment on lines
+21
to
+24
| onContentShare: () => {}, | ||
| onReviewEdit: () => {}, | ||
| onScheduleAdd: () => {}, | ||
| onScrapedChange: () => {}, |
There was a problem hiding this comment.
스토리북 8로 오면서 visual test를 사용할 때는 preview.tsx에 argTypesRegex을 사용하기 않기를 권장해서 제거했습니다.. onXX prop을 자동으로 넣어주다가 제거되어서 이벤트 핸들러 prop의 유무로 조건 렌더링을 하는 컴포넌트의 diff가 생기지 않게 하기 위해서 추가했습니다.
drakang4
force-pushed
the
storybook-upgrade
branch
from
adf1d53 to
3b15773
Compare
drakang4
force-pushed
the
storybook-upgrade
branch
from
3b15773 to
30e8b5f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 설명
스토리북 8 업그레이드
변경 내역
스크린샷 & URL
chromatic diff 없음