Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chat] aTagNavigator가 외부 브라우저에서 열리도록 수정합니다. #3551

Merged
merged 2 commits into from
Jan 22, 2025
Merged

[chat] aTagNavigator가 외부 브라우저에서 열리도록 수정합니다. #3551

merged 2 commits into from
Jan 22, 2025

Conversation

dongoc
Copy link
Contributor

@dongoc dongoc commented Jan 20, 2025 •
edited
Loading

PR 설명

aTagNavigator가 외부 브라우저에서 열리도록 수정합니다.

@dongoc dongoc added the chat label Jan 20, 2025
@dongoc dongoc added this to the v13.geochat-refactor milestone Jan 20, 2025
@dongoc dongoc self-assigned this Jan 20, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 10.10%. Comparing base (e6fba98) to head (9b85bf2).
Report is 2 commits behind head on epic/geochat.

Files with missing lines Patch % Lines
packages/chat/src/utils/a-tag-navigator.ts 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           epic/geochat    #3551      +/-   ##
================================================
- Coverage         10.10%   10.10%   -0.01%     
================================================
  Files               726      726              
  Lines             28218    28220       +2     
  Branches           7720     7720              
================================================
  Hits               2852     2852              
- Misses            25346    25348       +2     
  Partials             20       20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dongoc
Copy link
Contributor Author

dongoc commented Jan 20, 2025

release-canary

@github-actions GitHub Actions
Copy link

v13.34.1-pr-3551.52 has been published!

@dongoc
Copy link
Contributor Author

dongoc commented Jan 20, 2025

release-canary

@github-actions GitHub Actions
Copy link

v13.34.1-pr-3551.53 has been published!

@dongoc dongoc changed the title [chat] aTagNavigator에 preventDefault, stopPropagation 추가 [chat] aTagNavigator가 외부 브라우저에서 열리도록 수정합니다. Jan 20, 2025
@dongoc dongoc marked this pull request as ready for review January 20, 2025 23:57
@dongoc dongoc requested a review from a team as a code owner January 20, 2025 23:57
@dongoc dongoc requested review from zzolain, choisohyun, seulgiyoon and guswl98 and removed request for a team January 20, 2025 23:57
@dongoc dongoc merged commit 560355c into epic/geochat Jan 22, 2025
16 checks passed
@dongoc dongoc deleted the fix/a-tag-navigator branch January 22, 2025 04:25
This was referenced Jan 23, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guswl98 guswl98 guswl98 approved these changes

@zzolain zzolain Awaiting requested review from zzolain zzolain was automatically assigned from titicacadev/frontend

@choisohyun choisohyun Awaiting requested review from choisohyun choisohyun was automatically assigned from titicacadev/frontend

@seulgiyoon seulgiyoon Awaiting requested review from seulgiyoon seulgiyoon was automatically assigned from titicacadev/frontend

Assignees

@dongoc dongoc

Labels
chat
Projects
None yet
Milestone
v13.41.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dongoc @guswl98