[chat] 답장하기 버튼에 data-id 추가 #3556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## epic/geochat #3556 +/- ##
================================================
- Coverage 10.10% 10.10% -0.01%
================================================
Files 726 726
Lines 28220 28221 +1
Branches 7720 7720
================================================
Hits 2852 2852
- Misses 25348 25349 +1
Partials 20 20 ☔ View full report in Codecov by Sentry. |
|
release-canary |
|
v13.34.1-pr-3556.53 has been published! |
|
release-canary |
|
v13.34.1-pr-3556.55 has been published! |
|
release-canary |
|
v13.34.1-pr-3556.56 has been published! |
guswl98
requested review from
gigibean and
zhsks528
and removed request for
a team
dongoc
reviewed
Jan 23, 2025
| @@ -3,7 +3,8 @@ import { Container, Text } from '@titicaca/core-elements' | |||
| import { format, setDefaultOptions } from 'date-fns' | |||
| import { ko } from 'date-fns/locale' | |||
|
|
|||
| import { ReplyMessageIcon } from '../icons/reply-meesage-icon' | |||
| import { ReplyMessageIcon } from '../icons/reply-message-icon' | |||
dongoc
approved these changes
Jan 23, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 설명
reply button을 구분하기 위해 data-id를 추가합니다. chat-web에서 https://github.com/titicacadev/triple-chat-web/pull/397 이렇게 사용되고 있습니다.
변경 내역
ReplyActionButton에data-id를 추가합니다.ReplyActionButton에 사용되는data-id를 외부에서 사용할 수 있도록constants에 추가합니다.