Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Waypoint Implementation #156

Closed
wants to merge 0 commits into from
Closed

Drop Waypoint Implementation #156

wants to merge 0 commits into from

Conversation

technodante
Copy link

Resolves #150

Functionally, the drop waypoint acts the same as a normal waypoint, albeit with a field for the bottle number to be dropped.

@technodante technodante added type/feat A new feature/enhancement area/frontend Design and JS/React labels Jan 6, 2024
@technodante technodante self-assigned this Jan 6, 2024
krishnans2006
krishnans2006 requested changes Feb 3, 2024
View reviewed changes
Copy link
Member

@krishnans2006 krishnans2006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like both Type: Waypoint and Type: Drop add drop waypoints to the map - maybe you're accidentally overwriting standard path waypoints?

@technodante technodante closed this Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnans2006 krishnans2006 krishnans2006 requested changes

@tjuav tjuav Awaiting requested review from tjuav

Assignees

@technodante technodante

Labels
area/frontend Design and JS/React type/feat A new feature/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop Waypoints
2 participants
@technodante @krishnans2006