feat(git-fork): add flags comprehension #1053
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
reviewed
Jun 23, 2023
| @@ -0,0 +1,184 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
Could you move it to git-fork.html?
| 2. clones the repo into the current dir | ||
| 3. adds the original repo as a remote called `upstream` | ||
| 1. Forks the repo on GitHub. | ||
| 2. Clones the repo into the current directory or the one specified with `d` or `--target-dir`. |
There was a problem hiding this comment.
Suggested change
| 2. Clones the repo into the current directory or the one specified with `d` or `--target-dir`. | |
| 2. Clones the repo into the current directory or the one specified with `-d` or `--target-dir`. |
| local merged_opts_str="" | ||
| merged_opts_str+="$(printf "%s " "${s_opts[@]}")" | ||
| merged_opts_str+="$(printf "%s " "${l_opts[@]}")" | ||
| _git_changelog() { |
There was a problem hiding this comment.
Could you avoid changing the indent of other commands' functions? Thanks!
| if [[ "${cur}" == -* ]]; then | ||
| COMPREPLY=($(compgen -W "${opts}" -- ${cur})) | ||
| return 0 | ||
| else |
There was a problem hiding this comment.
We can use fi here or move the common return 0 out?
| for completion in $completions | ||
| echo $completion | ||
| end | ||
| return |
There was a problem hiding this comment.
It seems the execution is already return in every branch?
| local clone_dir="${target_dir:-$project}" | ||
| git clone "${remote_prefix}${user}/${project}.git" "$clone_dir" | ||
| # Add reference to the original fork for merging upstream changes | ||
| cd "$clone_dir" || exit |
There was a problem hiding this comment.
Should we exit with non-zero?
| [ -n "$user" ] || abort "GitHub username is required" | ||
|
|
||
| # Prompt for personal access token if not provided | ||
| if [ -z "$github_personal_access_token" ]; then |
There was a problem hiding this comment.
It seems we no longer get the token from git config anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially I just wanted to add support for directly forking the current repo (say you clone something, notice something you want/need to change, and you don't want to use
git-fork $(git remote get-url origin), so I added the-cand--currentflags for convenience, along with the help, token and target dir flags (because I'd rather keep my forks in ~/projects/forks, than the subdirectory of the upstream repo, which I usually keep in ~/src)