Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ruff linter with ci check #1182

Merged
merged 3 commits into from
Nov 28, 2024
Merged

feat: add ruff linter with ci check #1182

merged 3 commits into from
Nov 28, 2024

Conversation

oikarinen
Copy link
Contributor

@oikarinen oikarinen commented Nov 25, 2024

Linting the python files in tests directory would reduce whitespace etc change and enforce basic coding standard for those. Kind of opportunistic PR as there might be other opinions about how to deal with this.

Liniting the python files in tests directory would reduce whitespace etc
change and enforce basic coding standard for those. Kind of
opportunistic PR as there might be other opinions about how to deal with
this.
@oikarinen oikarinen changed the title Ruff feat: add ruff linter with ci check Nov 25, 2024
@spacewander
Copy link
Collaborator

Let's merge main branch.

@spacewander spacewander requested a review from vanpipy November 27, 2024 02:33
@spacewander
Copy link
Collaborator

@vanpipy
Please take a look if you have free time.

Copy link
Collaborator

@hyperupcall hyperupcall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. These changes are somewhat moot as at some point in the future, the tests will transition from using Python's Pytest to Bash's BATS testing framework

@vanpipy
Copy link
Collaborator

vanpipy commented Nov 27, 2024

LGTM. At least for now. Thank you so much :D.

@spacewander spacewander merged commit c23da8a into tj:main Nov 28, 2024
5 checks passed
@oikarinen oikarinen deleted the ruff branch December 25, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants