effort: handling of $'s and \n's, plus make shellcheck happy #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Shed light on the behaviour with/without `--` separator - Add more examples
nicolaiskogheim
commented
Jan 27, 2017
| if [ -z "$(head -c 1 <<<"$(echo "$path")")" ] | ||
| then | ||
| exit 0 | ||
| fi |
There was a problem hiding this comment.
It looks like printf (that produces output to effort) sends a final empty line when we call effort. That's the reason for this check.
|
Sorry for my missing of this. @nicolaiskogheim |
|
I'll fire up a FreeBSD box tomorrow and run the script just to be sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue that was reported this week, with
$'s in a filename breakinggit logand takegit effortwith it.git effortnow understands how to treat files with actual newlines in them as well.Shellcheck had some complaints, and I agreed to all of them. Because of that, there is a lot of code to review, so please look at each commit individually, if that makes it easier.
While I were at it, I expanded upon the docs, and made some small rewordings. If there are many comments on the doc edits, I'll split that out in it's own PR.
Please help test this
You can use this repo as a test repo. It contains files with names that should produce an error if the issue isn't fixed.