Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev): better fake data #1539

Merged
merged 1 commit into from
Jan 21, 2024
Merged

feat(dev): better fake data #1539

merged 1 commit into from
Jan 21, 2024

Conversation

NotFish232
Copy link
Member

Supercedes #1475

Proposed changes

  • delete long json and text files containing data
  • include scripts to generate data for users, scripts, and activities

Brief description of rationale

  • hard coding in data is bad practice
  • instead generate the data using scripts

@NotFish232 NotFish232 requested a review from shahsalonik as a code owner May 7, 2023 14:03
@coveralls
Copy link

coveralls commented May 7, 2023

Coverage Status

coverage: 80.169% (-0.02%) from 80.185%
when pulling 282cef0 on NotFish232:dev-random-data
into 3398826 on tjcsl:dev.

@NotFish232 NotFish232 force-pushed the dev-random-data branch 3 times, most recently from 2f73316 to 88f147f Compare May 7, 2023 14:34
Copy link
Member

@alanzhu0 alanzhu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve merge conflicts.

@NotFish232 NotFish232 closed this Sep 30, 2023
@NotFish232 NotFish232 reopened this Sep 30, 2023
@NotFish232 NotFish232 force-pushed the dev-random-data branch 2 times, most recently from ba5c079 to 505b922 Compare November 1, 2023 20:01
@alanzhu0
Copy link
Member

So, I suspect the CI is failing because it's an old run. But for some reason I can't re-run it. Can you just force push with no changes to trigger a re-run? After CI passes this is good for merge.

@NotFish232 NotFish232 force-pushed the dev-random-data branch 3 times, most recently from 5074835 to 5ca3059 Compare December 21, 2023 04:02
@NotFish232
Copy link
Member Author

I force pushed and CI still seems to be failing. Also reran ./scripts/build_sources.sh but no change.

@NotFish232 NotFish232 force-pushed the dev-random-data branch 4 times, most recently from df4762b to 3c1798e Compare January 21, 2024 18:23
Copy link
Member

@alanzhu0 alanzhu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Justin

@NotFish232
Copy link
Member Author

Thanks Alan Zhu.

@alanzhu0 alanzhu0 merged commit 60e9d92 into tjcsl:dev Jan 21, 2024
5 of 6 checks passed
@NotFish232 NotFish232 deleted the dev-random-data branch January 21, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants