Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(polls): add option to import from csv #1613

Merged
merged 1 commit into from
Jan 22, 2024
Merged

feat(polls): add option to import from csv #1613

merged 1 commit into from
Jan 22, 2024

Conversation

NotFish232
Copy link
Member

Proposed changes

  • Add option when creating polls to import from a csv

Brief description of rationale

  • Inputting election data is tedious and should be automated

@NotFish232 NotFish232 requested a review from a team as a code owner December 8, 2023 20:46
@NotFish232 NotFish232 changed the title feat(poll): add option to import from csv feat(polls): add option to import from csv Dec 8, 2023
@NotFish232 NotFish232 force-pushed the poll-from-csv branch 2 times, most recently from c0af776 to be5d53b Compare December 10, 2023 21:45
@coveralls
Copy link

coveralls commented Dec 10, 2023 •
edited
Loading

Coverage Status

coverage: 80.185% (+0.02%) from 80.169%
when pulling 80e8a46 on NotFish232:poll-from-csv
into 60e9d92 on tjcsl:dev.

alanzhu0
alanzhu0 requested changes Dec 21, 2023
View reviewed changes
Copy link
Member

@alanzhu0 alanzhu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. Small changes. Functionality looks good.

.gitignore Outdated Show resolved Hide resolved
intranet/static/js/polls.js Outdated Show resolved Hide resolved
intranet/static/js/vendor/jquery.csv.js Outdated Show resolved Hide resolved
intranet/templates/polls/vote.html Outdated Show resolved Hide resolved
@NotFish232 NotFish232 force-pushed the poll-from-csv branch 3 times, most recently from d4a4954 to 85f71d1 Compare December 21, 2023 04:10
@NotFish232 NotFish232 closed this Jan 22, 2024
@NotFish232 NotFish232 reopened this Jan 22, 2024
alanzhu0
alanzhu0 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@alanzhu0 alanzhu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alanzhu0 alanzhu0 merged commit d348d9c into tjcsl:dev Jan 22, 2024
5 of 6 checks passed
@NotFish232 NotFish232 deleted the poll-from-csv branch February 26, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanzhu0 alanzhu0 alanzhu0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NotFish232 @coveralls @alanzhu0