ref: convert mango_manager_module_run_duration_seconds to histogram

tjhop · Apr 9, 2024 · e6a23e8 · e6a23e8
1 parent 7375f23
commit e6a23e8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/internal/manager/metrics.go b/internal/manager/metrics.go
@@ -25,10 +25,11 @@ var (
 		[]string{"module", "script"},
 	)
 
-	metricManagerModuleRunDuration = promauto.NewGaugeVec(
-		prometheus.GaugeOpts{
-			Name: "mango_manager_module_run_duration_seconds",
-			Help: "Approximately how long it took for the module to run, in seconds",
+	metricManagerModuleRunDuration = prometheus.NewHistogramVec(
+		prometheus.HistogramOpts{
+			Name:    "mango_manager_module_run_duration_seconds",
+			Help:    "Histogram of durations of how long it took a given module to run, in seconds",
+			Buckets: prometheus.ExponentialBuckets(1, 2, 8),
 		},
 		[]string{"module", "script"},
 	)

diff --git a/internal/manager/module.go b/internal/manager/module.go
@@ -117,6 +117,7 @@ func (mgr *Manager) RunModule(ctx context.Context, logger *slog.Logger, mod Modu
 
 	labels := prometheus.Labels{
 		"module": mod.String(),
+		"script": "",
 	}
 
 	hostVarsMap := shell.MakeVariableMap(mgr.hostVariables)
@@ -152,7 +153,7 @@ func (mgr *Manager) RunModule(ctx context.Context, logger *slog.Logger, mod Modu
 		}
 
 		testEnd := time.Since(testStart)
-		metricManagerModuleRunDuration.With(labels).Set(float64(testEnd))
+		metricManagerModuleRunDuration.With(labels).Observe(float64(testEnd))
 	}
 
 	applyStart := time.Now()
@@ -169,7 +170,7 @@ func (mgr *Manager) RunModule(ctx context.Context, logger *slog.Logger, mod Modu
 	// update metrics regardless of error, so do them before handling error
 	applyEnd := time.Since(applyStart)
 	metricManagerModuleRunSuccessTimestamp.With(labels).Set(float64(applyStart.Unix()))
-	metricManagerModuleRunDuration.With(labels).Set(float64(applyEnd))
+	metricManagerModuleRunDuration.With(labels).Observe(float64(applyEnd))
 	metricManagerModuleRunTotal.With(labels).Inc()
 
 	if err != nil {