Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: adopt log/slog, remove go-kit/log #18

Merged
merged 2 commits into from
Sep 29, 2024
Merged

chore!: adopt log/slog, remove go-kit/log #18

merged 2 commits into from
Sep 29, 2024

Conversation

tjhop
Copy link
Owner

@tjhop tjhop commented Sep 28, 2024

The bulk of this PR was automated with a sed script that prometheus
folks are working on/using to help convert exporters:

https://gist.github.com/tjhop/49f96fb7ebbe55b12deee0b0312d8434

Signed-off-by: TJ Hoplock [email protected]

The bulk of this PR was automated with a sed script that prometheus
folks are working on/using to help convert exporters:

https://gist.github.com/tjhop/49f96fb7ebbe55b12deee0b0312d8434

Signed-off-by: TJ Hoplock <[email protected]>
@tjhop
Copy link
Owner Author

tjhop commented Sep 28, 2024

cc: @SuperQ testing on my own project and the only manual changes I needed to make were adjustments to bare logger.Error(err) statements, which caused linters to complain, so I decorated them a bit with better log messages and embedding the err as a keyval instead of using it directly as the message.

@tjhop tjhop merged commit 29e1153 into main Sep 29, 2024
1 check passed
@tjhop tjhop deleted the chore/adopt-slog branch September 29, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant