test: add unit test for chathistorybutton #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeola
commented
Oct 8, 2024
| @@ -55,6 +55,8 @@ const ChatHistoryButton = () => { | |||
| showChatHistory(); | |||
| }} | |||
| className="rcb-view-history-button" | |||
| role="button" | |||
There was a problem hiding this comment.
@tjtanjin By the way, is there why we can't just use a button tag here instead of a div? I'm not sure what the decision is and that is why I added the role instead.
There was a problem hiding this comment.
Hey @deeola, adding of role here is correct. As for your question, we go with a <div> for greater flexibility and consistency in layout and styling. This helps to minimize instances where the chatbot appears to be different when added to various websites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unit test for ChathHistoryButton
Closes #(issue)
[#146 ]
What change does this PR introduce?
Please select the relevant option(s).
What is the proposed approach?
Test for the following
Checklist: