Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit test cases for markupParser utils #203

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

vaibhavj2111
Copy link
Contributor

Description

Please include a brief summary of the change and include the relevant issue(s).

Closes #198

What change does this PR introduce?

Please select the relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes to docs/code comments)
  • Unit Test

What is the proposed approach?

Please give a short overview/explanation on the approach taken to resolve the issue(s).

Checklist:

  • The commit message follows our adopted guidelines
  • Testing has been done for the change(s) added (for bug fixes/features)
  • Relevant comments/docs have been added/updated (for bug fixes/features)

Copy link
Owner

@tjtanjin tjtanjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the test file is named incorrectly 😢 Kindly help to rename, thanks!

@vaibhavj2111
Copy link
Contributor Author

LGTM, but the test file is named incorrectly 😢 Kindly help to rename, thanks!

Oops 😿 , fixed it now. Any more changes required??

Copy link
Owner

@tjtanjin tjtanjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😊

@tjtanjin tjtanjin merged commit acfdaf4 into tjtanjin:main Oct 14, 2024
11 checks passed
RAVEYUS pushed a commit to RAVEYUS/react-chatbotify that referenced this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Add unit test cases for markupParser utils
2 participants