Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit tests for ToastsContext #235

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

Goketech
Copy link
Contributor

Description

This Pull requests introduces unit testing for ToastsContext.

Closes #233

What change does this PR introduce?

Please select the relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes to docs/code comments)

What is the proposed approach?

The proposed approach involves writing unit tests for ToastContext. The tests use render from the React testing library to test the toast context and behavior.

Checklist:

  • The commit message follows our adopted guidelines
  • Testing has been done for the change(s) added (for bug fixes/features)
  • Relevant comments/docs have been added/updated (for bug fixes/features)

Copy link
Owner

@tjtanjin tjtanjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Goketech, there are lint errors to be resolved 😞

@Goketech
Copy link
Contributor Author

Hey @Goketech, there are lint errors to be resolved 😞

Hi @tjtanjin,

I've resolved the lint error.
I noticed the workflow failed due to unit tests and these tests passed locally.

Could you take a look or re-run the job. 😔

@tjtanjin
Copy link
Owner

Hey @Goketech, there are lint errors to be resolved 😞

Hi @tjtanjin,

I've resolved the lint error.

I noticed the workflow failed due to unit tests and these tests passed locally.

Could you take a look or re-run the job. 😔

Hey @Goketech, the unit test failure isn't an issue on your end. Try merging the main branch 😃

Copy link
Owner

@tjtanjin tjtanjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😊

@tjtanjin tjtanjin merged commit eea831d into tjtanjin:main Oct 22, 2024
11 checks passed
RAVEYUS pushed a commit to RAVEYUS/react-chatbotify that referenced this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Add unit test cases for ToastsContext
2 participants