Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added testcases for BotStatesContext #242

Closed
wants to merge 17 commits into from
Closed

Conversation

Suvrat1629
Copy link
Contributor

Description

Please include a brief summary of the change and include the relevant issue(s).

Closes #227

What change does this PR introduce?

I have added testcases for BotStatesContext.

Please select the relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes to docs/code comments)

What is the proposed approach?

Please give a short overview/explanation on the approach taken to resolve the issue(s).
I have created the BotStatesContext.test.tsx file which has test cases for the BotStatesContext.

Checklist:

  • The commit message follows our adopted guidelines
  • Testing has been done for the change(s) added (for bug fixes/features)
  • Relevant comments/docs have been added/updated (for bug fixes/features)

Copy link
Owner

@tjtanjin tjtanjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Suvrat1629, this PR contains the exact same issues as the StylesContext PR (e.g. extra viteconfig file, deprecated library additions). It might help to clean up your branch first.

@Suvrat1629
Copy link
Contributor Author

ok i will work on that

@Suvrat1629
Copy link
Contributor Author

I have made the necessary changes please review it

@Suvrat1629
Copy link
Contributor Author

@tjtanjin updates?

Copy link
Owner

@tjtanjin tjtanjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflicts from the StylesContext file - this PR is only for BotStatesContext.

@Suvrat1629 Suvrat1629 closed this Oct 26, 2024
@Suvrat1629 Suvrat1629 reopened this Oct 26, 2024
@Suvrat1629
Copy link
Contributor Author

Ok I have resolved the conflicts

Copy link
Owner

@tjtanjin tjtanjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, just one last change - package.json and package-lock.json shouldn't be included here. There are no changes required of them. Good to merge after removing them, thanks!

@Suvrat1629
Copy link
Contributor Author

Suvrat1629 commented Oct 27, 2024

I dont understand what exactly you want me to do. Do you want me to remove and add the package.json and package-lock.json all over again? Cauz I am not able to see any conflicts so i opened the pr

@tjtanjin
Copy link
Owner

tjtanjin commented Oct 28, 2024

I dont understand what exactly you want me to do. Do you want me to remove and add the package.json and package-lock.json all over again? Cauz I am not able to see any conflicts so i opened the pr

There are no conflicts, but there are also no changes required to package.json and package-lock.json. This PR only requires a single file that is the BotStatesContext.test.tsx, so kindly help to remove the changes done to the 2 package files. Hope this clarifies!

@Suvrat1629
Copy link
Contributor Author

Ok i will open a new pr for this then

@Suvrat1629 Suvrat1629 closed this Oct 28, 2024
@Suvrat1629 Suvrat1629 deleted the new branch October 28, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Add unit test cases for BotStatesContext
2 participants