-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added testcases for BotStatesContext #242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Suvrat1629, this PR contains the exact same issues as the StylesContext PR (e.g. extra viteconfig file, deprecated library additions). It might help to clean up your branch first.
ok i will work on that |
I have made the necessary changes please review it |
@tjtanjin updates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge conflicts from the StylesContext file - this PR is only for BotStatesContext.
Ok I have resolved the conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, just one last change - package.json
and package-lock.json
shouldn't be included here. There are no changes required of them. Good to merge after removing them, thanks!
I dont understand what exactly you want me to do. Do you want me to remove and add the package.json and package-lock.json all over again? Cauz I am not able to see any conflicts so i opened the pr |
There are no conflicts, but there are also no changes required to |
Ok i will open a new pr for this then |
Description
Please include a brief summary of the change and include the relevant issue(s).
Closes #227
What change does this PR introduce?
I have added testcases for BotStatesContext.
Please select the relevant option(s).
What is the proposed approach?
Please give a short overview/explanation on the approach taken to resolve the issue(s).
I have created the BotStatesContext.test.tsx file which has test cases for the BotStatesContext.
Checklist: