Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/loading spinner test #267

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

cleobnvntra
Copy link
Contributor

Description

Added unit test for Loading Spinner component.

Closes #160

What change does this PR introduce?

Please select the relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes to docs/code comments)

What is the proposed approach?

The proposed approach focuses on validating the LoadingSpinner component’s rendering and styling based on settings and styles contexts. This approach includes:

  1. Rendering Verification: A test to confirm that both the spinner container and spinner elements are correctly rendered in the DOM.

  2. Primary Color Application: A test to ensure the spinner’s border color accurately reflects the primaryColor defined in the settings context, enhancing consistency with the overall theme.

  3. Custom Style Application: A test that verifies additional styling from the styles context is correctly applied to the spinner. This includes properties like border-radius, width, and height, ensuring that custom styles are honored.

Checklist:

  • The commit message follows our adopted guidelines
  • Testing has been done for the change(s) added (for bug fixes/features)
  • Relevant comments/docs have been added/updated (for bug fixes/features)

Copy link
Owner

@tjtanjin tjtanjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😊

@tjtanjin tjtanjin merged commit b4dfc23 into tjtanjin:main Nov 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Add unit test cases for LoadingSpinner component
2 participants