Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ChatHistoryService unit tests to cover a new storageType #277

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

SDaniV
Copy link
Contributor

@SDaniV SDaniV commented Nov 25, 2024

Description

Update unit test for ChatHistoryService

Closes #268

What change does this PR introduce?

Please select the relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes to docs/code comments)

What is the proposed approach?

The proposed approach adds a new parameter storageType: "SESSION_STORAGE" to most of the unit tests inside ChatHistoryService.test.ts file to cover both storage types without duplicating the test blocks.

Screenshots:

image

Checklist:

  • The commit message follows our adopted guidelines
  • Testing has been done for the change(s) added (for bug fixes/features)
  • Relevant comments/docs have been added/updated (for bug fixes/features)

Copy link
Owner

@tjtanjin tjtanjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tjtanjin tjtanjin merged commit 67705b6 into tjtanjin:main Nov 29, 2024
11 checks passed
@SDaniV SDaniV deleted the chatHistoryService-update-unit-tests branch December 4, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Update unit test for ChatHistoryService
2 participants