Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved issue-148 #278

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Solved issue-148 #278

merged 2 commits into from
Dec 2, 2024

Conversation

MadhurSaluja
Copy link
Contributor

@MadhurSaluja MadhurSaluja commented Nov 28, 2024

Description

This pull request enhances the unit tests for the ChatMessagePrompt component, ensuring all key functionalities are thoroughly validated. It addresses the visibility logic, hover styles, and scrolling behavior of the component.

Closes #148

What change does this PR introduce?

Please select the relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes to docs/code comments)

What is the proposed approach?

The approach includes adding and refining test cases for the ChatMessagePrompt component to cover the following scenarios:

  • Rendering with the correct message prompt text.
  • Applying the correct visible or hidden classes based on unread messages and scrolling state.
  • Ensuring hover styles are applied and reverted as expected.
  • Verifying that the scrolling behavior functions as intended, updating the scrolling state on completion.

Checklist:

  • The commit message follows our adopted guidelines
  • Testing has been done for the change(s) added (for bug fixes/features)
  • Relevant comments/docs have been added/updated (for bug fixes/features)

Copy link
Owner

@tjtanjin tjtanjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😊

@tjtanjin tjtanjin merged commit 3bdd5a4 into tjtanjin:main Dec 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Add unit test cases for ChatMessagePrompt component
2 participants