Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for gym==0.17.2 and scikit-image==0.17.2 #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tkukurin
Copy link

@tkukurin tkukurin commented Jun 3, 2020

max_episode_steps raises if info is None [1]. skimage import fix.

[1] https://github.com/openai/gym/blob/master/gym/wrappers/time_limit.py#L19

envs/block_pushing.py Outdated Show resolved Hide resolved
@tkipf
Copy link
Owner

tkipf commented Jun 3, 2020

Thanks for the PR. Does the max_episode_steps issue also affect OpenAI Gym version 0.12.0 (i.e., the version we use in this repository) or only later versions? I was also wondering why you added the from skimage import draw import, as the alias draw is not used in the rest of the file.

@tkukurin
Copy link
Author

tkukurin commented Jun 3, 2020

Sorry, it completely slipped my mind I'm running an environment with latest versions installed (gym==0.17.2 and scikit-image==0.17.2).

gym==0.12 works both when returning None or an empty dict from step().
With skimage there is an import issue and skimage.draw needs to be explicitly imported (I fixed it stylistically in the latest commit).

Basically this PR would update block_pushing to work with latest versions of the two libraries so feel free to disregard.

@tkipf
Copy link
Owner

tkipf commented Jun 3, 2020

Thanks for the explanation! I'll leave this PR open in case someone would want to use the code base with more recent versions of gym and scikit-image

@tkukurin tkukurin changed the title Minor fixes in block_pushing environment. Update for gym==0.17.2 and scikit-image==0.17.2 Jun 3, 2020
@tkukurin tkukurin changed the title Update for gym==0.17.2 and scikit-image==0.17.2 Update for gym==0.17.2 and scikit-image==0.17.2 Jun 3, 2020
@tkukurin
Copy link
Author

tkukurin commented Jun 3, 2020

Makes sense :)
Updated title and README to reflect actual change.

@tkipf
Copy link
Owner

tkipf commented Jun 3, 2020

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants