Skip to content

Commit

Permalink
Correctly download templated distributions from binary dependencies.
Browse files Browse the repository at this point in the history
  • Loading branch information
rschatz committed Feb 11, 2016
1 parent a623798 commit bd4b2f7
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions mx.py
Original file line number Diff line number Diff line change
Expand Up @@ -3763,7 +3763,7 @@ def getDistribution(self, vcdir, distribution):
if not distribution.needsUpdate(TimeStampFile(join(vcdir, _mx_binary_distribution_version(suiteName)), followSymlinks=False)):
return
metadata = self._readMetadata(vcdir)
artifactId = _map_to_maven_dist_name(distribution.name)
artifactId = distribution.maven_artifact_id()
path = distribution.path[:-len(distribution.localExtension())] + distribution.remoteExtension()
if distribution.isJARDistribution():
sourcesPath = distribution.sourcesPath
Expand Down Expand Up @@ -5647,9 +5647,6 @@ def _load_binary_suite(self):
self._load_suite_dict()
Suite._load_distributions(self, self._check_suiteDict('distributions'))

for dist in self.dists:
self.vc.getDistribution(self.dir, dist)

def _load_env(self):
pass

Expand All @@ -5658,6 +5655,11 @@ def _load_distributions(self, distsMap):
# so, in that mode, we don't want to call the superclass method again
pass

def _load_distribution(self, name, attrs):
ret = Suite._load_distribution(self, name, attrs)
self.vc.getDistribution(self.dir, ret)
return ret

def _register_metadata(self):
# since we are working with the original suite.py file, we remove some
# values that should not be visible
Expand Down

0 comments on commit bd4b2f7

Please sign in to comment.