-
Notifications
You must be signed in to change notification settings - Fork 20
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Show ocaml version in https://github.com/tlaplus/tlapm/actions/workflows
. Do not run python to translate an *opaque* array index into a meaningful ocaml version number. Moreover, commit 5e71b24 revealed a problem with this; it introduces an out-of-bounds read. [Build] Signed-off-by: Markus Alexander Kuppe <[email protected]>
- Loading branch information
Showing
3 changed files
with
8 additions
and
61 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -64,18 +64,14 @@ jobs: | |
macos-13, | ||
ubuntu-latest] | ||
ocaml-compiler: [ | ||
'2', | ||
'4.13.1', | ||
] | ||
steps: | ||
- name: Install deps | ||
if: matrix.operating-system == 'ubuntu-latest' | ||
run: | | ||
sudo apt-get update | ||
sudo apt-get install --yes time | ||
- name: Set up Python | ||
uses: actions/setup-python@v2 | ||
with: | ||
python-version: '3.10' | ||
# Read "Output Release URL and | ||
# ID File" of `release` job above. | ||
- name: Load Release URL File from release job | ||
|
@@ -94,17 +90,9 @@ jobs: | |
TAG_REF_NAME: ${{ github.ref }} | ||
REPOSITORY_NAME: ${{ github.repository }} | ||
- uses: actions/checkout@v2 | ||
- name: Get OCaml version | ||
run: | | ||
INDEX=${{ matrix.ocaml-compiler }} | ||
OCAML_VERSION=\ | ||
`python .github/workflows/ocaml_versions.py $INDEX` | ||
echo "OCAML_VERSION=$OCAML_VERSION" \ | ||
>> $GITHUB_ENV | ||
echo "OCAML_VERSION = $OCAML_VERSION" | ||
- uses: ocaml/setup-ocaml@v2 | ||
with: | ||
ocaml-compiler: ${{ env.OCAML_VERSION }} | ||
ocaml-compiler: ${{ matrix.ocaml-compiler }} | ||
# - uses: actions/cache@v3 | ||
# id: cache | ||
# with: | ||
|
@@ -122,7 +110,6 @@ jobs: | |
eval $(opam env) | ||
make test-inline test-fast-basic | ||
- name: Upload Release Asset | ||
if: matrix.ocaml-compiler == '2' | ||
id: upload-release-asset | ||
uses: actions/[email protected] | ||
env: | ||
|