Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
.

Do not run python to translate an *opaque* array index into a meaningful ocaml version number. Moreover, commit 5e71b24 revealed a problem with this; it introduces an out-of-bounds read.

[Build]

Signed-off-by: Markus Alexander Kuppe <[email protected]>
  • Loading branch information
lemmy committed Jun 7, 2024
1 parent 8facb9a commit fca876f
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 61 deletions.
20 changes: 6 additions & 14 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-13]
ocaml-compiler: ['0', '1']
ocaml-compiler: ['4.13.1', '5.1.0']
env:
EXAMPLES_DIR: "tlaplus-examples"
SCRIPT_DIR: "tlaplus-examples/.github/scripts"
Expand All @@ -26,21 +26,9 @@ jobs:
run: |
sudo apt-get update
sudo apt-get install --yes time
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.12'
- name: Get OCaml version
run: |
INDEX=${{ matrix.ocaml-compiler }}
OCAML_VERSION=\
`python .github/workflows/ocaml_versions.py $INDEX`
echo "OCAML_VERSION=$OCAML_VERSION" \
>> $GITHUB_ENV
echo "OCAML_VERSION = $OCAML_VERSION"
- uses: ocaml/setup-ocaml@v2
with:
ocaml-compiler: ${{ env.OCAML_VERSION }}
ocaml-compiler: matrix.ocaml-compiler
# - uses: actions/cache@v3
# id: cache
# with:
Expand All @@ -65,6 +53,10 @@ jobs:
with:
repository: tlaplus/examples
path: ${{ env.EXAMPLES_DIR }}
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.12'
- name: Check proofs in TLA+ examples
run: |
mkdir -p "$DEPS_DIR"
Expand Down
32 changes: 0 additions & 32 deletions .github/workflows/ocaml_versions.py

This file was deleted.

17 changes: 2 additions & 15 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,18 +64,14 @@ jobs:
macos-13,
ubuntu-latest]
ocaml-compiler: [
'2',
'4.13.1',
]
steps:
- name: Install deps
if: matrix.operating-system == 'ubuntu-latest'
run: |
sudo apt-get update
sudo apt-get install --yes time
- name: Set up Python
uses: actions/setup-python@v2
with:
python-version: '3.10'
# Read "Output Release URL and
# ID File" of `release` job above.
- name: Load Release URL File from release job
Expand All @@ -94,17 +90,9 @@ jobs:
TAG_REF_NAME: ${{ github.ref }}
REPOSITORY_NAME: ${{ github.repository }}
- uses: actions/checkout@v2
- name: Get OCaml version
run: |
INDEX=${{ matrix.ocaml-compiler }}
OCAML_VERSION=\
`python .github/workflows/ocaml_versions.py $INDEX`
echo "OCAML_VERSION=$OCAML_VERSION" \
>> $GITHUB_ENV
echo "OCAML_VERSION = $OCAML_VERSION"
- uses: ocaml/setup-ocaml@v2
with:
ocaml-compiler: ${{ env.OCAML_VERSION }}
ocaml-compiler: matrix.ocaml-compiler
# - uses: actions/cache@v3
# id: cache
# with:
Expand All @@ -122,7 +110,6 @@ jobs:
eval $(opam env)
make test-inline test-fast-basic
- name: Upload Release Asset
if: matrix.ocaml-compiler == '2'
id: upload-release-asset
uses: actions/[email protected]
env:
Expand Down

0 comments on commit fca876f

Please sign in to comment.