Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pct, pveversion: add page #13975

Merged
merged 28 commits into from
Jan 1, 2025
Merged

pct, pveversion: add page #13975

merged 28 commits into from
Jan 1, 2025

Conversation

Managor
Copy link
Collaborator

@Managor Managor commented Oct 4, 2024

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@Managor Managor requested a review from cyqsimon as a code owner October 4, 2024 06:08
@Managor Managor marked this pull request as draft October 4, 2024 06:08
@github-actions github-actions bot added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Oct 4, 2024
@Managor
Copy link
Collaborator Author

Managor commented Oct 4, 2024

Just a draft. I will probably be using this in the coming weeks and will contribute my findings here

@Managor Managor changed the title pvesh: add page pvesh, pct: add page Oct 4, 2024
@Managor
Copy link
Collaborator Author

Managor commented Oct 4, 2024

I do not know if the pct commands are valid. I followed this video, noticed they were almost identical to qm and coped qm.md

@Managor Managor changed the title pvesh, pct: add page pvesh, pct, pveversion: add page Oct 4, 2024
@Managor
Copy link
Collaborator Author

Managor commented Oct 4, 2024 •
edited
Loading

I was not able to find documentation for pveversion anywhere on the internet so I'll pull what I can from the Proxmox install
image

image

I wasn't able to find the source code of the man page even from the proxmox github repo.

@Managor Managor changed the title pvesh, pct, pveversion: add page pvesh, pct, pveversion, pvesm: add page Oct 4, 2024
@github-actions github-actions bot added the page edit Changes to an existing page(s). label Oct 4, 2024
@tldr-bot
Copy link

tldr-bot commented Oct 4, 2024

Hello! I've noticed something unusual when checking this PR:

  • The page pages/linux/vzdump.md already exists in the common directory.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@Managor Managor changed the title pvesh, pct, pveversion, pvesm: add page pvesh, pct, pveversion, pvesm vzdumo: add page; qmrestore: minor edit Oct 4, 2024
@Managor Managor changed the title pvesh, pct, pveversion, pvesm vzdumo: add page; qmrestore: minor edit pvesh, pct, pveversion, pvesm: add page; qmrestore: minor edit Oct 4, 2024
@Managor
Copy link
Collaborator Author

Managor commented Oct 5, 2024 •
edited
Loading

Correct me if I'm wrong, but Proxmox is Linux only, right?

@Managor Managor changed the title pvesh, pct, pveversion, pvesm: add page; qmrestore: minor edit pvesh, pct, pveversion, pvesm: add page; qmrestore: minor edit; vzdump: move location Oct 5, 2024
@Managor Managor changed the title pvesh, pct, pveversion, pvesm: add page; qmrestore: minor edit; vzdump: move location pvesh, pct, pveversion, pvesm: add page; qmrestore: minor edit Oct 5, 2024
@Managor Managor changed the title pvesh, pct, pveversion, pvesm: add page; qmrestore: minor edit pvesh, pct, pveversion, pvesm: add page Oct 5, 2024
@sebastiaanspeck
Copy link
Member

Correct me if I'm wrong, but Proxmox is Linux only, right?

You are correct, https://pve.proxmox.com/wiki/Installation

sebastiaanspeck
sebastiaanspeck reviewed Oct 5, 2024
View reviewed changes
pages/linux/pvesm.md Outdated Show resolved Hide resolved
pages/linux/pvesh.md Outdated Show resolved Hide resolved
@Managor Managor reopened this Dec 15, 2024
@Civon
Update pct.md: Revise commands and add new examples (#3)
ce6a358 
- Updated command descriptions to reflect accurate usage (start, stop, reboot).
- Added examples for accessing a container shell and resizing disks.
- Included new template-based container creation example.
- Introduced snapshot creation with description.
- Improved overall clarity and consistency in command syntax.
@CLAassistant
Copy link

CLAassistant commented Dec 15, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sebastiaanspeck
Copy link
Member

Is it still draft?

@Managor
Copy link
Collaborator Author

Managor commented Dec 15, 2024

Yeah pvesh and pvesm are still unfinished. @Civon Do you know any commands for those pages or shall I push them as is as a starting point?

@Managor Managor marked this pull request as ready for review December 15, 2024 18:10
@Managor
Copy link
Collaborator Author

Managor commented Dec 15, 2024

Actually, lets just review what we have here and push so that anyone can pick off where I left off.

@sbrl
Copy link
Member

sbrl commented Dec 18, 2024

Correct me if I'm wrong, but Proxmox is Linux only, right?

Proxmox is a distribution of Linux yes, but I imagine it can run windows as a VM.

@sebastiaanspeck sebastiaanspeck added the waiting Issues/PRs with Pending response by the author. label Dec 30, 2024
sbrl
sbrl requested changes Dec 30, 2024
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page! I've left some comments below for you to review.

pages/linux/pct.md Outdated Show resolved Hide resolved
pages/linux/pvesh.md Outdated Show resolved Hide resolved
pages/linux/pvesm.md Outdated Show resolved Hide resolved
pages/linux/pveversion.md Show resolved Hide resolved
@github-actions github-actions bot removed the waiting Issues/PRs with Pending response by the author. label Dec 30, 2024
@Managor Managor changed the title pvesh, pct, pveversion, pvesm: add page pct, pveversion: add page Dec 30, 2024
Civon
Civon approved these changes Jan 1, 2025
View reviewed changes
Copy link

@Civon Civon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience and contributions 🫰

@sebastiaanspeck sebastiaanspeck removed the page edit Changes to an existing page(s). label Jan 1, 2025
sbrl
sbrl approved these changes Jan 1, 2025
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sbrl sbrl merged commit ac6a6fc into tldr-pages:main Jan 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spageektti spageektti spageektti approved these changes

@Civon Civon Civon approved these changes

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

@sbrl sbrl sbrl approved these changes

@cyqsimon cyqsimon Awaiting requested review from cyqsimon cyqsimon is a code owner

Assignees

@Waples Waples

Labels
hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Managor @tldr-bot @sebastiaanspeck @spageektti @Civon @CLAassistant @sbrl @Waples