Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parted: refresh page, parted-interactive: add page #15432

Merged
merged 6 commits into from
Jan 5, 2025

Conversation

Managor
Copy link
Collaborator

@Managor Managor commented Jan 3, 2025

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@Managor Managor requested a review from cyqsimon as a code owner January 3, 2025 06:10
@github-actions github-actions bot added the page edit Changes to an existing page(s). label Jan 3, 2025
@Managor
Copy link
Collaborator Author

Managor commented Jan 3, 2025

Few things of note while doing housekeeping on this page:

The drive can be before or after --script. Moved to before because I think it looks nicer

The direct commands and interactive instructions don't mesh well in this page. I'm asking for opinions if we should separate these to parted.md and parted-interactive.md. This would free room for documenting the command itself for automation purposes.

@github-actions github-actions bot added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Jan 3, 2025
@Managor
Copy link
Collaborator Author

Managor commented Jan 3, 2025

I went ahead and did the initial split anyways before going to sleep.

pages/linux/parted-interactive.md Outdated Show resolved Hide resolved
@Managor Managor requested a review from kbdharun as a code owner January 3, 2025 14:44
@github-actions github-actions bot added the tooling Helper tools, scripts and automated processes. label Jan 3, 2025
@Managor Managor changed the title parted: refresh page parted: refresh page, parted-interactive: add page Jan 3, 2025
Copy link
Member

@spageektti spageektti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Co-authored-by: Sebastiaan Speck <[email protected]>
@tldr-bot
Copy link

tldr-bot commented Jan 5, 2025

Hello! I've noticed something unusual when checking this PR:

  • The page pages/linux/parted-interactive.md seems to be a copy of pages/linux/parted.md (76% matching).

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@sebastiaanspeck sebastiaanspeck merged commit 8a87d07 into tldr-pages:main Jan 5, 2025
4 checks passed
@Managor Managor deleted the parted branch January 8, 2025 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command. page edit Changes to an existing page(s). tooling Helper tools, scripts and automated processes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants