Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id: update documentation link #15537

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nelsonfigueroa
Copy link
Collaborator

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.

@github-actions github-actions bot added page edit Changes to an existing page(s). translation edit Changes to an existing translation page(s). labels Jan 17, 2025
@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The page pages.de/common/id.md is outdated, based on number of commands, compared to the English page.
  • The page pages.pt_BR/common/id.md is outdated, based on number of commands, compared to the English page.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@Managor
Copy link
Collaborator

Managor commented Jan 17, 2025

Is this necessary? They both lead to the same address.

@kbdharun
Copy link
Member

kbdharun commented Jan 17, 2025

Is this necessary? They both lead to the same address.

Yes, the redirects could break or not work in future so it is better to fix the link in the pages to reflect the actual one.


IMO instead of creating separate PRs for each page (and pinging all CODEOWNERS) we could update all the links in the English pages in a single PR and run the set more info script to sync links in the translation too.

I will try to work on this now to fix all the remaining links for coreutils. Done #15543

Copy link
Member

@kant kant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spanish translation: LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page edit Changes to an existing page(s). translation edit Changes to an existing translation page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants