Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sleep: add page #786

Merged
merged 1 commit into from
Feb 22, 2016
Merged

sleep: add page #786

merged 1 commit into from
Feb 22, 2016

Conversation

dawidd6
Copy link
Contributor

@dawidd6 dawidd6 commented Feb 22, 2016

Added sleep page

@oxguy3
Copy link
Contributor

oxguy3 commented Feb 22, 2016

LGTM! (well, except the missing period at the end of the description)

I will note though, the minutes and hours commands only work with the GNU coreutils version. The POSIX spec for sleep only requires that the sleep command support an integer number of seconds, and from the looks of OS X man pages, I think OS X's version only support the POSIX bare minimum. Thus, might be a good idea to have an osx version of this page in addition to the common version.

igorshubovych added a commit that referenced this pull request Feb 22, 2016
@igorshubovych igorshubovych merged commit 825d85c into tldr-pages:master Feb 22, 2016
@igorshubovych
Copy link
Collaborator

Thanks you!

@oxguy3 oxguy3 mentioned this pull request Feb 22, 2016
@oxguy3
Copy link
Contributor

oxguy3 commented Feb 22, 2016

Uhh, could someone with contribution privileges please fix this? Build of master branch is failing b/c of errors in this PR (would have helped if Travis CI didn't just arbitrarily ignore this PR and not show build status on it...)

@oxguy3 oxguy3 mentioned this pull request Feb 22, 2016
@igorshubovych
Copy link
Collaborator

Fixed.

@waldyrious waldyrious added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants