Add monaco editor and show it on click. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MitjaBezensek
commented
Nov 20, 2023
•
MitjaBezensek
commented
|
@MitjaBezensek is attempting to deploy a commit to the tldraw Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MitjaBezensek
force-pushed
the
mitja/add-code-editor
branch
from
ee7f6ee
to
3856c72
Compare
TodePond
reviewed
Nov 21, 2023
There was a problem hiding this comment.
Hey Mitja, first of all, this is awesome.
I just wanted to check this thing: The AI 'sees' something like this when we send it back an annotated website 👇
And it has no idea which one of these it looks like:
I wonder if we can change the SVG render to show it. Something like this?
What do you think? Might be interesting to play around with.
I also noticed a couple of design QA/UX points. Happy to go through them if you want!
MitjaBezensek
force-pushed
the
mitja/add-code-editor
branch
from
b6d3999
to
2f7a84b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.