Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for writing Normed{T,N} data #182

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

chrstphrbrns
Copy link
Contributor

Fix for #181

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 95.83333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.86%. Comparing base (8cd9370) to head (3420b60).

Files with missing lines Patch % Lines
src/ifds.jl 87.50% 1 Missing ⚠️
src/types/dense.jl 97.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage   92.36%   92.86%   +0.50%     
==========================================
  Files          14       14              
  Lines        1153     1192      +39     
==========================================
+ Hits         1065     1107      +42     
+ Misses         88       85       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/types/dense.jl Outdated Show resolved Hide resolved
@tlnagy
Copy link
Owner

tlnagy commented Jan 21, 2025

Thanks @chrstphrbrns, just a minor point about the function name and I'll merge this.

@tlnagy tlnagy merged commit 4ffd442 into tlnagy:master Jan 23, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants