-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type piracy issue #38
Conversation
This also fixes a pretty serious bug that caused |
Checking for contiguous strips allows me to recover the performance of master. julia> using TiffImages
julia> @time TiffImages.load("/home/tlnagy/Downloads/Gcamp6F_BSA_60px_3_stack.ome.tif");
Progress: 100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| Time: 0:00:01
2.724760 seconds (4.75 M allocations: 738.599 MiB, 2.18% gc time)
julia> @time TiffImages.load("/home/tlnagy/Downloads/Gcamp6F_BSA_60px_3_stack.ome.tif");
0.768867 seconds (286.85 k allocations: 513.183 MiB, 3.43% gc time)
julia> using ImageMagick
julia> @time ImageMagick.load("/home/tlnagy/Downloads/Gcamp6F_BSA_60px_3_stack.ome.tif");
4.143202 seconds (2.69 M allocations: 1.540 GiB, 5.18% gc time)
julia> @time ImageMagick.load("/home/tlnagy/Downloads/Gcamp6F_BSA_60px_3_stack.ome.tif");
3.236719 seconds (6.72 k allocations: 1.408 GiB, 0.72% gc time) |
d6b06c3
to
f2b2506
Compare
fixes the issue brought up by @timholy in #36 (comment)
Co-authored-by: Tim Holy <[email protected]>
check if striped data is contiguous and then read in as block
this fills a gap in the test suite that led to tlnagy/TiffImages.jl#38 (comment)
f2b2506
to
5dfef35
Compare
I created an artificial image that has its stripes offset by a random amount that should catch any regressions in handling discontiguously striped uncompressed images. |
Fixes the issue brought up by @timholy in #36 (comment). Added this branch to testing as well.