lure: individualized links for attribution #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fang-
reviewed
Aug 30, 2024
Co-authored-by: fang <[email protected]>
…nto hm/lure-attribution
Fang-
reviewed
Sep 3, 2024
Fang-
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the flow of lure so that now whoever is requesting a link will create an entry with the bait provider themselves (instead of the group host only, like the existing flow). Reel will send a nonce along with metadata and the bait provider will create the entry with a unique token and then return the nonce with the new token so that reel can update it's entries with the official token.
This creates a link to a particular group which is specific to us, allowing the inviter to start a DM with the joiner. We keep track of what links we've generated using a more stable identifier like group flag so we don't continuously generate new links every time the invite page is visited.