New %contacts agent #283
Merged
New %contacts agent #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikolajpp
force-pushed
the
mp/contacts
branch
3 times, most recently
from
9b87ac4 to
4b35132
Compare
mikolajpp
force-pushed
the
mp/contacts
branch
from
90c93f5 to
9382767
Compare
Fang-
requested changes
Sep 19, 2024
arthyn
reviewed
Sep 19, 2024
mikolajpp
force-pushed
the
mp/contacts
branch
2 times, most recently
from
f35d637 to
723717c
Compare
mikolajpp
force-pushed
the
mp/contacts
branch
2 times, most recently
from
02ac5fb to
36cbc66
Compare
lib-subscriber expects that subscription wires contain enough information to differentiate subscriptions, which is not true for in %contacts: the /contact wire does not carry peer information.
mikolajpp
force-pushed
the
mp/contacts
branch
from
36cbc66 to
730eb97
Compare
arthyn
reviewed
Oct 1, 2024
arthyn
requested changes
Oct 1, 2024
|
I successfully migrated a moon and was able to update profile information without changing the frontend (after the requested change) |
Does editing a profile work from the existing front-end? |
|
@jamesacklin yep |
Co-authored-by: Hunter Miller <[email protected]>
|
Thank you. Let's keep this off |
The .saga field of $foreign used to be defined as a nullable type $@(~ saga). However, $saga itself can take on atomic values, breaking the semantics of $@. Hoon compiler does not catch this error at compile time, however validating the type (and any type containing it) is going to fail.
mikolajpp
force-pushed
the
mp/contacts
branch
from
e81e94e to
384939f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new %contacts agent supports a user-defined contact book. To that end, new types and state are introduced. The agent remains backward compatible on local (
/news) endpoint, while foreign subscriptions are now managed withlib-negotiateand exposed over versioned endpoints. Implements TLON-2620.