Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spansy): add AsRef<Span<[u8]>> impl for Span<str> #20

Merged
merged 1 commit into from
Feb 8, 2024
Merged

feat(spansy): add AsRef<Span<[u8]>> impl for Span<str> #20

merged 1 commit into from
Feb 8, 2024

Conversation

sinui0
Copy link
Member

@sinui0 sinui0 commented Feb 5, 2024

This PR impls AsRef<Span<[u8]>> for Span. This adds some flexibility when working with types containing both kinds of spans.

@sinui0 sinui0 requested review from themighty1 and th4s February 5, 2024 23:19
themighty1
themighty1 requested changes Feb 7, 2024
View reviewed changes
spansy/src/lib.rs Show resolved Hide resolved
th4s
th4s approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@th4s th4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sinui0 sinui0 merged commit b1a3b01 into dev Feb 8, 2024
2 checks passed
@sinui0 sinui0 deleted the feature/str-span-asref-bytes branch February 8, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themighty1 themighty1 themighty1 requested changes

@th4s th4s th4s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sinui0 @themighty1 @th4s