Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): integrate rewrite changes #584

Merged
merged 17 commits into from
Sep 18, 2024

Conversation

sinui0
Copy link
Member

@sinui0 sinui0 commented Sep 11, 2024

This PR integrates the changes from #574 into the rest of our crates.

@sinui0 sinui0 force-pushed the refactor/core-rewrite-integration branch from dfeca19 to e635043 Compare September 11, 2024 23:05
@sinui0 sinui0 marked this pull request as ready for review September 11, 2024 23:05
Copy link
Member

@th4s th4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 very nice 🚀

some non-blocking questions and comments

crates/benches/bin/prover.rs Show resolved Hide resolved
crates/core/src/attestation/config.rs Outdated Show resolved Hide resolved
crates/core/src/presentation.rs Outdated Show resolved Hide resolved
crates/examples/simple/simple_prover.rs Outdated Show resolved Hide resolved
crates/examples/simple/simple_prover.rs Outdated Show resolved Hide resolved
crates/formats/src/http/mod.rs Show resolved Hide resolved
crates/prover/src/prove.rs Outdated Show resolved Hide resolved
crates/tls/mpc/src/follower.rs Show resolved Hide resolved
crates/verifier/src/notarize.rs Outdated Show resolved Hide resolved
@sinui0 sinui0 force-pushed the refactor/core-rewrite branch from bc75ed9 to 5118309 Compare September 18, 2024 04:36
@sinui0 sinui0 merged commit 3e789d9 into refactor/core-rewrite Sep 18, 2024
@sinui0 sinui0 deleted the refactor/core-rewrite-integration branch September 18, 2024 16:42
sinui0 added a commit that referenced this pull request Sep 19, 2024
* refactor(core): alpha.7 rewrite

* allow empty idx

* fix empty assumption

* further encapsulate rangeset

* added presentation, finishing touches

* remove unwrap

* update index naming

* add secp256r1 support

* add attestation to presentation output, and serde derives

* handle k256 in KeyAlgId Display

* unnecessary newline

* refactor(core): integrate rewrite changes (#584)

* refactor(core): alpha.7 rewrite

* allow empty idx

* fix empty assumption

* further encapsulate rangeset

* added presentation, finishing touches

* remove unwrap

* refactor(core): integrate rewrite changes

* remove obsolete tests

* add secp256r1 support

* update index naming

* add secp256r1 support

* add attestation to presentation output, and serde derives

* handle k256 in KeyAlgId Display

* unnecessary newline

* fix variable name

* restore changes from dev to tlsn-prover

* use CryptoProvider in config

* clippy

* more clippy
@themighty1 themighty1 restored the refactor/core-rewrite-integration branch October 24, 2024 12:41
@themighty1 themighty1 deleted the refactor/core-rewrite-integration branch October 24, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants