Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a script to set the TLSN version number of the relevant crates #650

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

heeckhau
Copy link
Member

Follow up of #642

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.74%. Comparing base (85e0f5b) to head (dfd8ef2).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #650      +/-   ##
==========================================
+ Coverage   55.55%   55.74%   +0.18%     
==========================================
  Files         193      189       -4     
  Lines       20854    20769      -85     
==========================================
- Hits        11585    11577       -8     
+ Misses       9269     9192      -77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuroitaki
Copy link
Member

noice~ btw will this bump the version in notary's openapi.yaml too :P ?

@heeckhau
Copy link
Member Author

It does not, it only changes the Cargo.toml files

@heeckhau heeckhau requested a review from yuroitaki December 3, 2024 09:55
Copy link
Member

@yuroitaki yuroitaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

crates/notary/server/openapi.yaml Show resolved Hide resolved
set_tlsn_version.rs Show resolved Hide resolved
@yuroitaki yuroitaki self-requested a review December 4, 2024 09:07
@heeckhau heeckhau force-pushed the set_version_script branch 2 times, most recently from ef25ac0 to 247e3e6 Compare December 5, 2024 08:49
@heeckhau heeckhau merged commit 7bec5a8 into dev Dec 12, 2024
9 checks passed
@heeckhau heeckhau deleted the set_version_script branch December 12, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants