Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compress partial transcript #653

Merged
merged 3 commits into from
Dec 26, 2024
Merged

feat: compress partial transcript #653

merged 3 commits into from
Dec 26, 2024

Conversation

themighty1
Copy link
Member

This PR enables the prover to compress the partial transcript when sending it to the verifier.

Also renames the field PartialTranscript::sent_authed to sent_authed_idx to minimize cognitive burden when analyzing the compression logic.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 95.06173% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.95%. Comparing base (7bec5a8) to head (1646a6b).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
crates/core/src/transcript.rs 95.06% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #653      +/-   ##
==========================================
+ Coverage   55.74%   55.95%   +0.21%     
==========================================
  Files         189      189              
  Lines       20769    20813      +44     
==========================================
+ Hits        11577    11646      +69     
+ Misses       9192     9167      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@themighty1 themighty1 requested a review from sinui0 October 24, 2024 09:08
@yuroitaki yuroitaki self-requested a review December 3, 2024 15:16
Copy link
Member

@yuroitaki yuroitaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@themighty1 themighty1 merged commit c03418a into dev Dec 26, 2024
9 checks passed
@themighty1 themighty1 deleted the feat/compress_transcript branch December 26, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants