-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poseidon circomlib #670
base: dev
Are you sure you want to change the base?
Poseidon circomlib #670
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #670 +/- ##
==========================================
+ Coverage 55.95% 55.96% +0.01%
==========================================
Files 189 192 +3
Lines 20813 20875 +62
==========================================
+ Hits 11646 11683 +37
- Misses 9167 9192 +25 ☔ View full report in Codecov by Sentry. |
c6fcdd6
to
1311c48
Compare
Sorry, the last force-push was me pressing the "Update with rebase" button. I was expecting GH to show that it made the rebase, not I. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! love the generic implementation that caters for all rates up to 16 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds a functionality to compute a Poseidon hash compatible with https://github.com/iden3/circomlib/blob/master/circuits/poseidon.circom
The build script generates the Poseidon constants and writes them to file.