-
-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracing: Added Langsmith Support #1069
Open
jubeless
wants to merge
10
commits into
tmc:main
Choose a base branch
from
streamingfast:feature/langsmith
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubeless
commented
Nov 21, 2024
@@ -13,7 +13,6 @@ import ( | |||
//nolint:all | |||
type Handler interface { | |||
HandleText(ctx context.Context, text string) | |||
HandleLLMStart(ctx context.Context, prompts []string) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This call was dead code, it was not called anywhere
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces LangSmith tracing to the langchaingo library, enhancing debugging and monitoring capabilities for applications leveraging large language models (LLMs). These changes align with our observability needs and have been successfully running in production for several months.
We have subsequent PR ready to improve Inputs and Outputs capturing streamingfast#4
Key Features
LangSmith Tracing Integration:
callbacks.Handler
to enable tracing capabilities.Refactor and Enhancements:
chains.Call
.chain.Call
was not passed to thellm.Model
instance.Backward Compatibility
No breaking changes have been introduced. Tracing is optional and does not affect existing functionality when disabled.
Future Improvements
Refactor HandleLLMGenerateContentStart and HandleLLMGenerateContentEnd into a centralized GenerateContent function in the llms package to reduce code duplication across llms models.
PR Checklist
memory: add interfaces for X, Y
orutil: add whizzbang helpers
).Fixes #123
).golangci-lint
checks.