Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the Kit interface [https://github.com/tmc/langchaingo/issues/1103] #1117

Closed
wants to merge 5 commits into from

Conversation

amritsingh183
Copy link

Checkout #1103

This PR implements the Kit interface which can help standardize the usage of the functionality offered by this interface i-e a convenient way (for third party tool providers or even if you want use it yourself in your code) of making a group of tools (Kit) available to the agent

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

tools/tool.go Outdated Show resolved Hide resolved
tools/tool_test.go Outdated Show resolved Hide resolved
tools/tool_test.go Outdated Show resolved Hide resolved
@amritsingh183
Copy link
Author

@FluffyKebab I have addressed your feedback, please review the changed code

@amritsingh183
Copy link
Author

@FluffyKebab just a friendly ping for review.

@catpower
Copy link

catpower commented Feb 3, 2025

Do you know what kind of person Tavis Cline is? Collaborating with someone like this is truly a disgrace! Check out this report: https://www.globalcryptoreporter.com/nvidia-engineer-at-center-of-8-million-crypto-scam-tech-giants-name-exploited-in-ai-driven-fraud/

@amritsingh183
Copy link
Author

i came to know about this project from langchain. Then i saw the stars on this repo. I have no idea about the person you are talking about

@amritsingh183
Copy link
Author

plus, I am doing this for myself and for the open source community and not for the person you are referring to

@amritsingh183
Copy link
Author

amritsingh183 commented Feb 3, 2025

and obviously i don't go on github and research about the project owner or maintainers. So in context of your comment, "would be a disgrace, if you knew about it", would have been appropriate as compared to "is a disgrace"

@amritsingh183 amritsingh183 deleted the add-tool-box branch February 3, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants