Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embeddings: refactor EmbedderClient interface to reduce code duplication #358

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

eliben
Copy link
Collaborator

@eliben eliben commented Nov 19, 2023

Starting with the vertex embedder, but this is applicable to others too.

The common code fixes the combined vector issue, similarly to #357, for #356

This replaces a completely duplicated method in two places with a common function; the same function can be used for the embedders of other LLMs as well, if this approach is deemed good.

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

Starting with the vertex embedder, but this is applicable to others too
Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thank you. LGTM

@tmc tmc merged commit 26bd994 into tmc:main Nov 20, 2023
3 checks passed
@eliben
Copy link
Collaborator Author

eliben commented Nov 20, 2023

Thanks @tmc - I'd be happy to apply this to other embeddings backends, but it's not clear to me why there are two at all - why is there one instance of LLM and one of Chat with the same embeddings methods and implementations? E.g. https://github.com/tmc/langchaingo/blob/main/embeddings/ollama/ollamachat/ollama_chat.go#L31 and https://github.com/tmc/langchaingo/blob/main/embeddings/ollama/ollama.go#L32 -- could you clarify?

tmc pushed a commit that referenced this pull request Dec 5, 2023
…ion (#358)

Starting with the vertex embedder, but this is applicable to others too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants