Towards nix lib path discovery #65
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the first viable one.
…found library error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nix package for cuda seems to move files towards use of a singular path structure for all platforms. This seems somewhat reasonable but is surprising when we encounter it as clients. In this PR Ive widened the lib search paths to allow for multiple possible paths per arch/os, and added the nix version the linux search paths.
In nix terms I was born yesterday so if anyone has a better approach Id like to hear it. For this Cuda library specifically I wonder if it would be better to only use the search paths to produce error text and encourage all clients to configure some additional env correctly? Is that already there and Im missing it?
Thanks
A