Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seed hiding controlled by cmd line option #722

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

flend
Copy link
Collaborator

@flend flend commented Nov 3, 2024

Adds a --hide-seed command line option that hides the seed display when playing. This is used in web-brogue where seeds are obscured to players until the end of game to avoid players trivially practising the same seed offline.

seedafter

@flend flend force-pushed the feature/hide_seed branch from ddd82d2 to cd2e087 Compare November 9, 2024 16:56
@tmewett
Copy link
Owner

tmewett commented Nov 14, 2024

What's the wider rationale for this? web-brogue seed tournaments?

@flend
Copy link
Collaborator Author

flend commented Nov 16, 2024

What's the wider rationale for this? web-brogue seed tournaments?

I got feedback that an exploit that people were uncomfortable with was that you could start a random-seeded game online, check the seed, play the same seed offline a few times and then return to the online game. This is relevant if people are competing for masteries or longest streak (see recent posts on brogueforum). I don't consider it particularly important, but it felt like a general good practice to make this non-trivial to achieve.

This is part of the patch set that goes onto CE for web-brogue and I'm always keen to reduce the patch set if I can mainstream features.

@tmewett
Copy link
Owner

tmewett commented Dec 1, 2024

Makes sense to me, thanks!

@tmewett tmewett merged commit 411bc06 into tmewett:release Dec 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants