Use tmux's default-shell opt to get preffered SHELL for default-command in OSX
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmand` in OSX tmux-sensible modified `default-command` for OSX to use `reattach-to-user-namespace` when creating shell with user preffered shell type from `SHELL` environment variable for circumventing OSX's process namespace segregation. Prior to tmux 3.5 this `SHELL` environment variable was not modified by Tmux when running a shell command with tmux's default `sh` shell, so this worked fine. Now from tmux 3.5 `SHELL` environment variable is set to `sh`, this causes tmux to load `sh` shell when executing default-command instead of user preffered shell when using tmux-sensible plugin.
|
@bruno- can you please validate and pull this MR? |
|
@bruno- I've got a friendly reminder to pull this changes. |
Enzime
suggested changes
Dec 3, 2024
| @@ -100,7 +105,7 @@ main() { | |||
|
|
|||
| # required (only) on OS X | |||
| if is_osx && command_exists "reattach-to-user-namespace" && option_value_not_changed "default-command" ""; then | |||
There was a problem hiding this comment.
According to the reattach-to-user-namespace documentation, this command is no longer necessary after Tmux 2.6 so I think it would be great if you could change the condition to only set the default-command based on the version of tmux
webframp
added a commit
to webframp/dotfiles
that referenced
this pull request
Dec 10, 2024
There's a bug between current tmux 3.5a and tmux-sensible@25cb91f that makes it always use sh instead of correct $SHELL https://discourse.nixos.org/t/tmux-use-bash-instead-defined-zsh-in-home-manager/54763/2 nix-community/home-manager#5952 will need fix here: - tmux-plugins/tmux-sensible#75 but I may not actually need sensible at all with home-manager tmux config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tmux-sensible modified
default-commandfor OSX to usereattach-to-user-namespacewhen creating shell with user preffered shell type fromSHELLenvironment variable for circumventing OSX's process namespace segregation.Prior to tmux 3.5 this
SHELLenvironment variable was not modified by Tmux when running a shell command with tmux's defaultshshell, so this worked fine.Now from tmux 3.5
SHELLenvironment variable is set tosh, this causes tmux to loadshshell when executing default-command instead of user preffered shell when using tmux-sensible plugin.This fixes the issue.