Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout: highlights when layout is not in default state #1006

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

alexveden
Copy link
Contributor

This pull request introduces a new option for highlighting non-default layout:

layout.highlight_if_not = us

Does the following:
Default layout
image

Non-default;
image

Previous plugin behavior preserved, if option not set, no highlighting for both layouts.

@alexveden
Copy link
Contributor Author

BTW, when I was working on layout module, it seems there are 2 layout.py in core and contrib dirs. Bumblebee-status picks the contrib verison, I don't know if this is an issue or intentional. Maybe more clarity is required in the docs.

@tobi-wan-kenobi
Copy link
Owner

Oh, I did not notice the issue regarding duplicate module names, I will certainly investigate that. Thanks for mentioning this and thanks for the cool PR!

@tobi-wan-kenobi tobi-wan-kenobi merged commit f0324bd into tobi-wan-kenobi:main Dec 10, 2023
3 of 7 checks passed
@tobi-wan-kenobi
Copy link
Owner

This might be functionality that could be nice in the framework itself - add a highlight group if a widget does (not) have a certain value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants